-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha for release notes - #543 #604
gha for release notes - #543 #604
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
=======================================
+ Coverage 97.4% 98.0% +0.6%
=======================================
Files 26 37 +11
Lines 4328 6068 +1740
=======================================
+ Hits 4214 5946 +1732
- Misses 114 122 +8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the categories, something like
- API changes
- Enhancements
- Bug fixes
- Deprecations
- Documentation
- Other
? I am not a fan of having type (e.g. enhancement) and content (e.g. preprocessing) mixed together. I also don't think that refactoring needs to be included as it should not affect user in any way.
@@ -41,6 +41,16 @@ jobs: | |||
draft: false | |||
prerelease: false | |||
|
|||
- name: Create Release Notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that this will conflict with Create GitHub Release above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that this will conflict with Create GitHub Release above
Yeah, more than likely. We will have to work that out iteratively seems like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need one or the other. Also note that removing the one above will break the last one which uses steps.create_release.outputs.upload_url
. In any case, actions/create-release
is archived so we shall find a new way of doing things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think things are more simple than I thought. We can simply prune down the current momepy
action to get our desired result. That final step
We can see in the v0.7.0
release there are 3 assets there.
momepy-0.7.0.tar.gz
Source code (zip)
Source code (tar.gz)
However, momepy-0.7.0.tar.gz
and Source code (tar.gz)
are the exact same thing, just different names - that's what Upload Release Asset (sdist) to GitHub is doing (and it's not needed).
I'm going to make some adjustments and push up (what I hope is) the fix.
Co-authored-by: Martin Fleischmann <martin@martinfleischmann.net>
So maybe like:
The thing is that we don't have labels for all and will have go back through all Issues & PRs to add those new labels once they are created. @martinfleis |
I am happy to do that.
|
Roger that. OK, I'll add |
@martinfleis this is ready for review. once merged I will see about a tag + release of |
Same |
gha for release notes - #543
spopt
and the one here inmomepy
differ considerably -- will have to see how adding the "create release notes" interacts here